Skip to content

refactor: update stats/base/scumin native addon from C++ to C #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 2, 2025
Merged

refactor: update stats/base/scumin native addon from C++ to C #4433

merged 4 commits into from
Jan 2, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • adds C addons to stats/base/scumin instead of c++ addons

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/scumin $\color{green}467/467$
$\color{green}+100.00\%$ 		$\color{green}49/49$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}467/467$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
kgryte
kgryte reviewed Jan 2, 2025
View reviewed changes
kgryte
kgryte reviewed Jan 2, 2025
View reviewed changes
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 2, 2025
kgryte
kgryte approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jan 2, 2025
@kgryte kgryte merged commit d24f1dd into stdlib-js:develop Jan 2, 2025
13 checks passed
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@vivekmaurya001 @stdlib-bot @0PrashantYadav0
refactor: update stats/base/scumin native addon from C++ to C
87786a4 
PR-URL: stdlib-js#4433
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@vivekmaurya001 @stdlib-bot @Neerajpathak07
refactor: update stats/base/scumin native addon from C++ to C
f34520d 
PR-URL: stdlib-js#4433
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@vivekmaurya001 @stdlib-bot @ShabiShett07
refactor: update stats/base/scumin native addon from C++ to C
e471e64 
PR-URL: stdlib-js#4433
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekmaurya001 @stdlib-bot @kgryte